Allow initial sizing of BinaryFuseBuilder #56
Merged
+112
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `MakeBinaryFuseBuilder` which pre-initializes a binary fuse builder to a certain initial size, guaranteeing no allocations up to that size. This avoids reallocations as the buffers grow. We also improve the `reuseBuffer` method to use an `append` pattern (relying on the internal formulas for slice growth) and isolate the unsafe hack to the single place where it is needed now (fingerprints slice).
Member
|
@RaduBerinde This one is an easy merge. (I have not forgotten about the other PR, but it is not as easy to review, I won't delay forever.) |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify segment count calculation
Allow initial sizing of BinaryFuseBuilder
Add
MakeBinaryFuseBuilderwhich pre-initializes a binary fusebuilder to a certain initial size, guaranteeing no allocations up to
that size. This avoids reallocations as the buffers grow.
We also improve the
reuseBuffermethod to use anappendpattern(relying on the internal formulas for slice growth) and isolate the
unsafe hack to the single place where it is needed now (fingerprints
slice).