Open
Conversation
Collaborator
|
Where's the user story for this? You've linked it to the user journey. |
Collaborator
|
Also, this needs to be reviewed by your teammates first so removing assignment for me and Mario for now. |
claireinez
requested review from
SamiSha99 and
nj-io
and removed request for
Karyum and
claireinez
SamiSha99
approved these changes
Jan 24, 2018
Collaborator
SamiSha99
left a comment
SamiSha99
left a comment
There was a problem hiding this comment.
Looks good for me, I don't see any issues to comment on.
Open
claireinez
requested changes
Jan 24, 2018
| res.writeHead(200, {"Content-Type": "text/html"}); | ||
| res.end("Invalid username or password"); | ||
| } else { | ||
| var cookie = jwt.sign(JSON.stringify(result), process.env.SECRET); |
Collaborator
There was a problem hiding this comment.
Why var and not const?
| text-decoration: none; | ||
| color: #fff; | ||
| } | ||
| font-family: Roboto; |
Collaborator
There was a problem hiding this comment.
There should be a fallback font if the user doesn't have this font
| </LandingNavbar> | ||
|
|
||
| <SignupDiv> | ||
| <form className="form-3" action='/api/newUser' method='POST'> |
Collaborator
There was a problem hiding this comment.
What kind of a classname is this? form-3 tells me nothing...
src/js/Login.jsx
Outdated
| return (<div> | ||
|
|
||
| <LoginDiv> | ||
| <form onSubmit={this.handleSubmit} action="/api/login" method="POST" className="form-3"> |
Collaborator
There was a problem hiding this comment.
What is this classname???
| if (err) { | ||
| cb(err); | ||
| } else { | ||
| // console.log('post.rows:', post.rows); |
Collaborator
There was a problem hiding this comment.
Get rid of this commented out code
| if(err){ | ||
| return cb(err) | ||
| } | ||
| if(res.rows.length==0){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #6 , set up the authentication , and a routing for the userPage