feat: support async onShouldStartLoad requests

[kbulgakov-exo]

The existing approach with locking the main thread to make a synchronous call asking JS "can I proceed with this URL" isn't reliable. Even the recent timeout bump to 500ms #47 didn't help, we still experience the loading issues. Bumping the timeout even more (for example with #48) would inevitably lead to performance degradation because of the locked thread. We should come up with a more reliable solution

The bottleneck

I've put some logs to diagnose what exactly is the bottleneck. The JS callback works super fast, but the problem is that sometimes it seems to be called after Native already makes the decision after the 500ms default timeout:

 Timeline:
  0ms      Native dispatches event
           |
           |  (JS thread busy)
           |
  501ms    Native TIMEOUT → blocks navigation
           |
 >501ms   JS receives event, responds "allow"
           |
           ✗ Response ignored - decision already made 

The solution

Let's mirror the async architecture of the onShouldStartLoad calls from https://github.com/react-native-webview/react-native-webview. We can easily backport most of the code.

I recommend reviewing commit by commit

Notes:

• the first commit cherry-picks WebViewDecisionManager from upstream with minor formatting changes
• the other commits rely on the upstream code as well, but with a few minor changes to conform to our codebase. I’m going to leave the code references below.

Testing

• WebView loads content normally when JS responds with true
• WebView rejects loading when JS responds with false

[kbulgakov-exo]

Reference: https://github.com/react-native-webview/react-native-webview/blob/5bc526fce5b9d6225df183bdf3d8cf542007d90a/apple/RNCWebViewImpl.m#L1366-L1386

The allowing code is moved into the allowNavigation helper to be reused below to keep the old fallback behavior

[kbulgakov-exo]

Reference: https://github.com/react-native-webview/react-native-webview/blob/5bc526fce5b9d6225df183bdf3d8cf542007d90a/apple/RNCWebViewModule.mm#L21

[kbulgakov-exo]

tACK

• WebView loads content normally when JS responds with true
• WebView rejects loading when JS responds with false

[guten-exodus]

utACK nice

[kbulgakov-exo]

@guten-exodus Could you check whether this also addresses the pain points you had in Pay?

[timlanahan]

@ChALkeR please review

[guten-exodus]

Could you check whether this also addresses the pain points you had in Pay?

Tested, worked great!

[kewdex]

doesn't look very thread safe - not sure if it needs to be though

• the ++ isn't an atomic add operation, so two threads calling it at the same time are essentially getting the same lock identifier. Since I believe this will only be called from the main thread, I think this is fine-ish (?)

But NSMutableArray isn't thread safe, so if multiple threads are adding & removing things at the same time then things may go wrong :| 

setDecisionHandler is called from webView:decidePolicyForNavigationAction which runs on the main thread afaik and setResult is exported to React Native to be called from JS which is another thread? So there might be some rare race conditions here

[kbulgakov-exo]

Tested b6cad2e, all good. Thanks!

[kewdex]

utACK