Feature/sof 5666 - generate dft_functionals.json in install hook#197
Open
adewyer wants to merge 6 commits intoepic/SOF-5386from
Open
Feature/sof 5666 - generate dft_functionals.json in install hook#197adewyer wants to merge 6 commits intoepic/SOF-5386from
dft_functionals.json in install hook#197adewyer wants to merge 6 commits intoepic/SOF-5386from
Conversation
tjduigna
reviewed
Feb 9, 2022
functionals.py
Outdated
| UNIT_FUNCTIONALS_PATH = os.path.join(BASE_DIR, REL_DIR) | ||
| PROTOTYPE_FILENAME = os.path.join(UNIT_FUNCTIONALS_PATH, "dft_unit_functionals_proto.json") | ||
| UNIT_FILENAME = os.path.join(UNIT_FUNCTIONALS_PATH, "dft_unit_functionals.json") | ||
| DATA_FILENAME = os.path.join(BASE_DIR, "src/py/esse/data", REL_DIR, "dft_unit_functionals.json") |
Contributor
There was a problem hiding this comment.
Since the schema directory itself is where the symlinking occurs, DATA_FILENAME should no longer be necessary.
tjduigna
reviewed
Feb 9, 2022
functionals.py
Outdated
| import os | ||
| import sys | ||
| import json | ||
| import errno |
Contributor
There was a problem hiding this comment.
We stopped using the force_symlink function so this import is no longer needed.
timurbazhirov
changed the title
dft_functionals.json in install hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.