Draft: Adventure: Introduce WorldEdit to an adventure #2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor some vanilla methods to sponge api * Fixes * Update api 14 * Fixes * PR fixes * Bring back vanilla methods
Remove a redundant passenger check, as entity.save() returns false in that case.
This also causes leash knots to not be copied. I don't think this is a problem because:
- They would not be saved to disk, it's misleading for users that they appear.
- Pasted leashed mobs still think they're leashed to the original position and get unleashed* - no change in behaviour.
\* Unless they're pasted close enough to the original position, in which case this has better behaviour because they create their own leash_knot entity.
…neHub#2757) Hacky workaround by overwriting the text3 StyleSerializer class with our own modified copy. Note that the hover events "show_entity" and "show_item" aren't supported as they no longer take a rendered component, but just the NBT structure. Behavior remains unchanged if 1.21.4- is detected. Fixes EngineHub#2756.
Joo200
force-pushed
the
feature/adventure-time
branch
from
4932f32 to
bd8b6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started a new adventure after I was able to make the changes for EngineHub/Piston#40
I applied the piston version with adventure 4.14.0 to worldedit and fixed many compilation errors and improved the usage of adventure at some points.
I tested the changes on paper but it should work fine on fabric, forge and sponge too.
However
This is a breaking change. WorldGuard uses the relocated text serializers from WorldEdit to send messages and initialize flags by using the LegacyComponentSerializer. I'm confident to replace kyori-text by shading adventure in WorldGuard or by introducing the breaking change into WG 7.1.x.