Add Folia basic support; #2379
Draft
Add Folia basic support; #2379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement scheduler methods in Bukkit Entity;
octylFractal
reviewed
Aug 3, 2023
Member
octylFractal
left a comment
octylFractal
left a comment
There was a problem hiding this comment.
I'm unsure this covers all the changes we'd need to be properly folia-supportive, but one thing for sure is I don't think we want to expose SchedulerAdapter + these Entity methods as full API. I think those belong specifically in the Bukkit section. I'm not sure we'd even like to have them be public there, but that's a discussion I'd need to have with the rest of the dev team.
|
When testing whether this project would build in Ubuntu I did encounter a build failure. I pasted it in mclogs |
Member
|
Yes, the new API must be accepted. |
Euphillya
added a commit
to Euphillya/WorldEdit-Folia
that referenced
this pull request
Dec 21, 2023
I use this PR : EngineHub#2379
Closed
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds adapters for schedulers. Required for Bukkit and Folia schedulers.
Created schedulers can be used in WorldGuard and in other plugins;