Skip to content

Add tracing for env volume loading #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osipovartem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tracing for env volume loading #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ datafusion-expr = { version = "50.0.0" }
datafusion-functions-json = { git = "https://github.com/Embucket/datafusion-functions-json.git", rev = "439cbd2282504c3ffaf262f1ffdb530a0fb1a151" }
datafusion-macros = { version = "50.0.0" }
datafusion-physical-plan = { version = "50.0.0" }
datafusion_iceberg = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "f76b73573267304d2f866ed0dba91587f928caa6" }
datafusion_iceberg = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "c1c8152ed67dc6ebf06bddf9c5e87bbf3de3b83d" }
futures = { version = "0.3" }
http = "1.2"
http-body-util = "0.1.0"
iceberg = { git = "https://github.com/apache/iceberg-rust.git", rev="7a5ad1fcaf00d4638857812bab788105f6c60573"}
iceberg-rest-catalog = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "f76b73573267304d2f866ed0dba91587f928caa6" }
iceberg-rust = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "f76b73573267304d2f866ed0dba91587f928caa6" }
iceberg-rust-spec = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "f76b73573267304d2f866ed0dba91587f928caa6" }
iceberg-s3tables-catalog = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "f76b73573267304d2f866ed0dba91587f928caa6" }
iceberg-rest-catalog = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "c1c8152ed67dc6ebf06bddf9c5e87bbf3de3b83d" }
iceberg-rust = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "c1c8152ed67dc6ebf06bddf9c5e87bbf3de3b83d" }
iceberg-rust-spec = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "c1c8152ed67dc6ebf06bddf9c5e87bbf3de3b83d" }
iceberg-s3tables-catalog = { git = "https://github.com/Embucket/iceberg-rust.git", rev = "c1c8152ed67dc6ebf06bddf9c5e87bbf3de3b83d" }
indexmap = "2.7.1"
jsonwebtoken = "9.3.1"
lazy_static = { version = "1.5" }
Expand Down
2 changes: 2 additions & 0 deletions crates/catalog-metastore/src/metastore_bootstrap_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ impl MetastoreBootstrapConfig {
pub async fn load_from_env() -> Result<Self, ConfigError> {
let mut config = Self::default();
if let Some(volume) = load_volume_from_env().await? {
tracing::info!("Loading volume from environment");
config.volumes.push(volume);
}
Ok(config)
Expand Down Expand Up @@ -437,6 +438,7 @@ async fn load_volume_from_env() -> Result<Option<VolumeEntry>, ConfigError> {
.await?;

validate_s3tables_credentials(&arn, &credentials).await?;
tracing::info!("Loaded volume has been validated");

VolumeType::S3Tables(S3TablesVolume {
endpoint: None,
Expand Down
Loading