Addressed PHP 8.3 deprecation notices#49
Open
sc0ttdav3y wants to merge 1 commit intoElephant418:masterfrom
Open
Addressed PHP 8.3 deprecation notices#49sc0ttdav3y wants to merge 1 commit intoElephant418:masterfrom
sc0ttdav3y wants to merge 1 commit intoElephant418:masterfrom
Conversation
This was referenced Sep 24, 2024
|
Hi - is this planned to be merged soon? i'm getting the same error upgrading to php 8.3 |
Member
|
I can work on it next week. Thanks for your help <3 |
|
@tzi: how did you get on? Would be good to get this added to a new release 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the work in #48, and adds additional properties to fix the deprecation notices since PHP 8.3:
I have not been able to test via the included tests, as PHPUnit is still at v4 and this is no longer compatible with PHP 8.3 (and I don't have the time to upgrade it in this PR), however this is a minimal change so it should not have any new bugs.