Skip to content

Fix inline spacing fixer for empty tag #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzi merged 2 commits into from
Feb 4, 2018
Merged

Fix inline spacing fixer for empty tag #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
161266d
Adjust fixInlineElementSpacing to not trigger for emptyTags
SL-Gundam Feb 3, 2018
460c512
Adjusted test case for this commit d0da9e0fae21d160bef3e6c16dbfd5d0fe…
SL-Gundam Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Converter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,7 +1360,7 @@ protected function fixBlockElementSpacing()
*/
protected function fixInlineElementSpacing()
{
if ($this->parser->isStartTag) {
if ($this->parser->isStartTag && !$this->parser->isEmptyTag) {
// move spaces after the start element to before the element
if (preg_match('~^(\s+)~', $this->parser->html, $matches)) {
$this->out($matches[1]);
Expand Down
2 changes: 1 addition & 1 deletion test/ConverterTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ public function providerFixBreaks()
$data['break1']['html'] = "<strong>Hello,<br>How are you doing?</strong>";
$data['break1']['md'] = "**Hello, \nHow are you doing?**";
$data['break2']['html'] = "<b>Hey,<br> How you're doing?</b><br><br><b>Sorry<br><br> You can't get through</b>";
$data['break2']['md'] = "**Hey, \nHow you're doing?** \n \n**Sorry \n \nYou can't get through**";
$data['break2']['md'] = "**Hey, \nHow you're doing?** \n \n**Sorry \n \nYou can't get through**";

return $data;
}
Expand Down