-
Notifications
You must be signed in to change notification settings - Fork 35
example: Simplified version of a TCP Chargen server based on this library #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new example demonstrating a TCP Character Generator Protocol (Chargen) server implementation using the AsyncTCP library. The example follows RFC 864 and shows how to handle asynchronous client connections, send continuous data streams, and manage buffer space efficiently.
Key changes:
- Adds a complete Chargen server example that listens on port 19 and sends rotating patterns of ASCII characters
- Implements single-client connection handling with rejection of additional clients when busy
- Uses async callbacks (onAck, onPoll, onDisconnect) to manage data flow without blocking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Missing space after variable name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I am sorry I am unable to understand the proper way to submit my little file. I will practice outside of you proyect. |
Hi,
edit: Ah forget about the above: that's not true for AsyncTCP project ;-) What's really important is to look at the build issues. All should be green. But I can help you with that |
|
@jnovonj : also, Github is experiencing a lot of issues today (https://www.githubstatus.com) so that is why the CI checks are nor properly working for now. We can try again tomorrow to refresh / re-execute the checks. |
|
Hi, I have already see the HTTP 503 errors, do not worry. You and your colleges should be proud of your job in this projects. From a remote desktop I have been inspired by you to develop this little project. I encourage to follow in your job. Best Regards. P.D. I love the changes 😃 |
|
We have a CI job running on each PR which is checking and reformatting the code |
This is only a little example of a Character Generator Protocol https://en.wikipedia.org/wiki/Character_Generator_Protocol based on this library.
More information in this discussion: #102