Skip to content

Conversation

@jnovonj
Copy link

@jnovonj jnovonj commented Dec 11, 2025

This is only a little example of a Character Generator Protocol https://en.wikipedia.org/wiki/Character_Generator_Protocol based on this library.

More information in this discussion: #102

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new example demonstrating a TCP Character Generator Protocol (Chargen) server implementation using the AsyncTCP library. The example follows RFC 864 and shows how to handle asynchronous client connections, send continuous data streams, and manage buffer space efficiently.

Key changes:

  • Adds a complete Chargen server example that listens on port 19 and sends rotating patterns of ASCII characters
  • Implements single-client connection handling with rejection of additional clients when busy
  • Uses async callbacks (onAck, onPoll, onDisconnect) to manage data flow without blocking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jnovonj and others added 8 commits December 11, 2025 15:03
Missing space after variable name

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jnovonj jnovonj closed this Dec 11, 2025
@jnovonj
Copy link
Author

jnovonj commented Dec 11, 2025

I am sorry I am unable to understand the proper way to submit my little file. I will practice outside of you proyect.

@mathieucarbou mathieucarbou reopened this Dec 11, 2025
@mathieucarbou
Copy link
Member

mathieucarbou commented Dec 11, 2025

I am sorry I am unable to understand the proper way to submit my little file. I will practice outside of you proyect.

Hi,
What you did was good!
These are just review comments generated by Copilot: this is an AI agent automatically helping PR review.
You need to take his comments with grain of salt because some are relevant but a lot are not usually ;-)

Your PR only miss some macro (check the other examples) because we do support some boards on ETH without WiFi and in this case WiFi is not available. So you could have a look how we setup WiFi on the other example and do a copy paste.

So far that's the only thing I saw that is missing ;-)

edit: Ah forget about the above: that's not true for AsyncTCP project ;-)

What's really important is to look at the build issues. All should be green. But I can help you with that

@mathieucarbou
Copy link
Member

@jnovonj : also, Github is experiencing a lot of issues today (https://www.githubstatus.com) so that is why the CI checks are nor properly working for now. We can try again tomorrow to refresh / re-execute the checks.

@jnovonj
Copy link
Author

jnovonj commented Dec 11, 2025

Hi, I have already see the HTTP 503 errors, do not worry.

You and your colleges should be proud of your job in this projects.

From a remote desktop I have been inspired by you to develop this little project.

I encourage to follow in your job.

Best Regards.

P.D. I love the changes 😃

- AsyncServer* AsyncServerChargen = nullptr;
+ AsyncServer *AsyncServerChargen = nullptr;

@mathieucarbou
Copy link
Member

We have a CI job running on each PR which is checking and reformatting the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants