Skip to content

300-Allow-the-MDLTableWidget-to-be-paginated#304

Open
juliendelplanque wants to merge 15 commits intoDuneSt:developmentfrom
juliendelplanque:300-Allow-the-MDLTableWidget-to-be-paginated
Open

300-Allow-the-MDLTableWidget-to-be-paginated#304
juliendelplanque wants to merge 15 commits intoDuneSt:developmentfrom
juliendelplanque:300-Allow-the-MDLTableWidget-to-be-paginated

Conversation

@juliendelplanque
Copy link
Contributor

Implemented pagination for MDLTableWidget.
Used a strategy design pattern to achieve that, the strategy is used to generate html for the content of the table.
Implemented tests.

Fix #300

@juliendelplanque
Copy link
Contributor Author

Not entirely finished, there is still a bug with the pagination size selection..

@coveralls
Copy link

coveralls commented Apr 1, 2020

Pull Request Test Coverage Report for Build 613

  • 113 of 204 (55.39%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 65.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Material-Design-Lite-Widgets/MDLTableWidget.class.st 26 38 68.42%
src/Material-Design-Lite-Widgets/MDLDisplayPaginatedTableContent.class.st 69 148 46.62%
Totals Coverage Status
Change from base Build 602: -0.4%
Covered Lines: 3400
Relevant Lines: 5190

💛 - Coveralls

juliendelplanque and others added 5 commits April 1, 2020 20:16
Co-Authored-By: CyrilFerlicot <cyril@ferlicot.me>
…nt.class.st

Co-Authored-By: CyrilFerlicot <cyril@ferlicot.me>
…nt.class.st

Co-Authored-By: CyrilFerlicot <cyril@ferlicot.me>
…ePossibilities message return an empty collection.

Added test to check it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the MDLTableWidget to be paginated

3 participants