WIP: Add GFX ([MS-RDPEGFX]) support #648
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on ironrdp-pdu/gfx code. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Use the dedicated ironrdp-egfx crate instead. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Member
|
Converted to draft to hint that the PR is WIP. |
Contributor
|
Hi @elmarco - thanks for starting this work. I'm building on IronRDP for a More speficically I've implemented some server-side EGFX functionality that might complement
Are you planning to continue this PR? If so, I'd be happy to contribute these Let me know what works best. Thanks, |
Contributor
Author
|
hi @glamberson! feel free to close this PR once you have one that supersedes it. thanks! |
glamberson
pushed a commit
to glamberson/IronRDP
that referenced
this pull request
Dec 16, 2025
Extends the EGFX server implementation with complete server-side support for H.264/AVC420 video streaming. This builds on the foundation from PR Devolutions#648 by @elmarco. Server enhancements: - State machine for capability negotiation workflow - Surface creation and mapping to output - Frame sending with StartFrame/WireToSurface1/EndFrame sequence - Flow control via FrameAcknowledge tracking - Configurable backpressure (max frames in flight) - Output queue for proactive frame transmission New H.264 utilities: - `Avc420Region` - Region metadata for H.264 frames - `annex_b_to_avc()` - Convert Annex B to AVC format (length-prefixed NALs) - `align_to_16()` - Align dimensions to H.264 macroblock boundaries - `encode_avc420_bitmap_stream()` - Create AVC420 bitmap streams The server now supports the full EGFX protocol flow: 1. Client sends CapabilitiesAdvertise 2. Server responds with CapabilitiesConfirm (V8.1 with AVC420) 3. Server sends ResetGraphics, CreateSurface, MapSurfaceToOutput 4. For each frame: StartFrame → WireToSurface1 → EndFrame 5. Client sends FrameAcknowledge for flow control Refs: Devolutions#427 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
glamberson
pushed a commit
to glamberson/IronRDP
that referenced
this pull request
Dec 16, 2025
Add complete MS-RDPEGFX implementation with PDU types and server logic. PDU layer (based on work by @elmarco in Devolutions#648): - All 23 RDPGFX PDUs (WireToSurface, CreateSurface, ResetGraphics, etc.) - Capability sets V8 through V10.7 - AVC420/AVC444 bitmap stream codecs - Timestamp, QuantQuality, and supporting types Server implementation: - Multi-surface management (Offscreen Surfaces ADM element) - Frame tracking with flow control (Unacknowledged Frames ADM element) - V8/V8.1/V10/V10.1-V10.7 capability negotiation - AVC420 and AVC444 frame sending - QoE metrics processing - Cache import handling - Resize coordination - Backpressure via client queue depth Client-side DVC processor (from Devolutions#648): - Basic message processing scaffolding Credits: @elmarco for PDU definitions and protocol research in PR Devolutions#648. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
glamberson
pushed a commit
to glamberson/IronRDP
that referenced
this pull request
Dec 16, 2025
Add complete MS-RDPEGFX implementation with PDU types and server logic. PDU layer (based on work by @elmarco in Devolutions#648): - All 23 RDPGFX PDUs (WireToSurface, CreateSurface, ResetGraphics, etc.) - Capability sets V8 through V10.7 - AVC420/AVC444 bitmap stream codecs - Timestamp, QuantQuality, and supporting types Server implementation: - Multi-surface management (Offscreen Surfaces ADM element) - Frame tracking with flow control (Unacknowledged Frames ADM element) - V8/V8.1/V10/V10.1-V10.7 capability negotiation - AVC420 and AVC444 frame sending - QoE metrics processing - Cache import handling - Resize coordination - Backpressure via client queue depth Client-side DVC processor (from Devolutions#648): - Basic message processing scaffolding Credits: @elmarco for PDU definitions and protocol research in PR Devolutions#648.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably left out in this PR, since I'd rather focus on AVC444 atm:
See also #427