-
Notifications
You must be signed in to change notification settings - Fork 664
DataGrid: fix Tab press handler in filter range (T1312521) #32199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 26_1
Are you sure you want to change the base?
Conversation
4dc7c60 to
a2e2895
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the DataGrid filter row code by removing unnecessary/redundant code and improving type safety and test organization.
Changes:
- Refactored filter range overlay container positioning to be relative to grid headers instead of viewport
- Improved Tab key navigation logic to handle the last column edge case
- Enhanced type safety by adding MenuInternal type import and removing TypeScript error suppressions
- Reorganized TestCafe tests by separating visual and functional tests into dedicated files
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/filterRow.tests.js |
Added helper function getFilterRowOverlay() to simplify test assertions and updated all overlay selector references |
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts |
Changed overlay container from viewport to grid element, improved Tab navigation to handle last column, added MenuInternal type, removed unnecessary blur trigger |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/visual.ts |
New file containing visual/screenshot tests previously in functional.ts |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts |
Removed visual tests (moved to visual.ts), cleaned up imports, reorganized test order |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/T1163100_changeFIlterIcon.visual_matrix.ts |
New test file for T1163100 filter icon change visual tests |
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/filterRow.tests.js
Show resolved
Hide resolved
a2e2895 to
b023fac
Compare
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts:170
- The test uses
test.onlywhich will cause other tests in this file to be skipped during test execution. This should be changed totestbefore merging to ensure all tests run in CI.
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts:205 - The test uses
test.onlywhich will cause other tests in this file to be skipped during test execution. This should be changed totestbefore merging to ensure all tests run in CI.
0df1985 to
b0b94a7
Compare
b0b94a7 to
4ba0ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
No description provided.