Skip to content

T1311329 - DataGrid - Column chooser hides a banded column on using search and recursive selection #32186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmirgaev merged 14 commits into from
Jan 19, 2026
Merged

T1311329 - DataGrid - Column chooser hides a banded column on using search and recursive selection #32186

dmirgaev merged 14 commits into from
Jan 19, 2026
+490 −25

Conversation

@Raushen
Copy link
Contributor

@Raushen Raushen commented Jan 13, 2026

No description provided.

@Raushen Raushen self-assigned this Jan 13, 2026
@Raushen Raushen requested a review from a team as a code owner January 13, 2026 22:42
Copilot AI review requested due to automatic review settings January 13, 2026 22:42
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug (T1311329) where the DataGrid column chooser incorrectly hides a banded (parent) column when using search functionality with recursive selection enabled. The issue occurred because column visibility was being updated without considering the relationship between banded columns and their children.

Changes:

  • Refactored column visibility update logic to handle banded columns correctly by processing them in sorted order (non-band columns first, then band columns)
  • Added integration tests to verify the fix for both the search scenario and direct toggling of banded columns
  • Created reusable test model classes (TreeViewModel, TextBoxModel, CheckBoxModel, ColumnChooserModel) to support the new tests

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Refactored column visibility logic to correctly handle banded columns by sorting nodes and determining visibility based on child column states
packages/devextreme/js/__internal/grids/grid_core/column_chooser/tests/column_chooser.integration.test.ts Added comprehensive integration tests for the banded column visibility fix
packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/grid_core.ts Added getColumnChooser method to support column chooser testing
packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/column_chooser.ts Created model class for interacting with column chooser in tests
packages/devextreme/js/__internal/ui/tests/mock/model/tree_view.ts Created reusable model for TreeView interactions in tests
packages/devextreme/js/__internal/ui/tests/mock/model/textbox.ts Created reusable model for TextBox interactions in tests
packages/devextreme/js/__internal/ui/tests/mock/model/checkbox.ts Created reusable model for CheckBox interactions in tests

Copilot AI review requested due to automatic review settings January 15, 2026 02:25
Copilot AI reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings January 15, 2026 03:21
Copilot AI reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings January 16, 2026 06:32
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Copilot AI review requested due to automatic review settings January 16, 2026 17:43
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts
visibleColumnsLevel0 = instance.getVisibleColumns(0);
visibleColumnsLevel1 = instance.getVisibleColumns(1);

expect(visibleColumnsLevel0.find((col) => col.caption === 'Contacts')).toBeDefined();
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test uses .toBeDefined() which passes even when find() returns undefined. This assertion will always pass because find() always returns a value (either an object or undefined), and undefined.toBeDefined() is true. Use .toBeTruthy() or check the result with .not.toBeUndefined() for the intended behavior.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 19, 2026 14:17
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@dmirgaev dmirgaev merged commit 5e47317 into DevExpress:26_1 Jan 19, 2026
99 of 100 checks passed
dmirgaev added a commit to dmirgaev/DevExtreme that referenced this pull request Jan 19, 2026
@Raushen @dmirgaev
T1311329 - DataGrid - Column chooser hides a banded column on using s…
50665f1 
…earch and recursive selection (DevExpress#32186)

Co-authored-by: Danil Mirgaev <danil.mirgaev@devexpress.com>
dmirgaev added a commit to dmirgaev/DevExtreme that referenced this pull request Jan 19, 2026
@Raushen @dmirgaev
T1311329 - DataGrid - Column chooser hides a banded column on using s…
92588f5 
…earch and recursive selection (DevExpress#32186)

Co-authored-by: Danil Mirgaev <danil.mirgaev@devexpress.com>
dmirgaev added a commit that referenced this pull request Jan 19, 2026
@dmirgaev @Raushen
T1311329 - DataGrid - Column chooser hides a banded column on using s…
f00e956 
…earch and recursive selection (#32186) (#32237)

Co-authored-by: Andrey Dolzhikov <16618553+Raushen@users.noreply.github.com>
dmirgaev added a commit that referenced this pull request Jan 19, 2026
@dmirgaev @Raushen
T1311329 - DataGrid - Column chooser hides a banded column on using s…
f7dbe2a 
…earch and recursive selection (#32186) (#32238)

Co-authored-by: Andrey Dolzhikov <16618553+raushen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@anna-shakhova anna-shakhova anna-shakhova approved these changes

Assignees

@Raushen Raushen

Labels

26_1 skip-cache type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Raushen @anna-shakhova @dmirgaev