Skip to content

Conversation

@jakebailey
Copy link
Member

Due to webpack/tapable#195

I don't think this test actually matters, it seemed to be left behind in #51712.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 2, 2025

@jakebailey Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73806,
  "author": "jakebailey",
  "headCommitOid": "e3dfc742c041438a147558a6a5034fbac39d4ea9",
  "mergeBaseOid": "2b3eb5f699a2574c60e8fbd24c1b9120753a3762",
  "lastPushDate": "2025-10-02T21:02:46.000Z",
  "lastActivityDate": "2025-10-02T21:02:46.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "tapable",
      "kind": "edit",
      "files": [
        {
          "path": "types/tapable/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/tapable/tapable-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "e-cloud",
        "johnnyreilly"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3363040304,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @e-cloud @johnnyreilly — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Oct 2, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 2, 2025
@jakebailey jakebailey merged commit e680e51 into DefinitelyTyped:master Oct 2, 2025
4 checks passed
@jakebailey jakebailey deleted the fix-tapabale branch October 2, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants