Skip to content

Conversation

@suhoij
Copy link

@suhoij suhoij commented Dec 7, 2016

I've added the "Authorization" header in order to support OAuth 2.0 authorization flow.

@jzabel
Copy link

jzabel commented Dec 7, 2016

@suhoij - thanks for suggesting this change to support Hubspots OAuth 2 functionality. Some suggestions on the fix.

Per their docs, you should only send it in the auth header (oauth) or on the string (hapikey): http://developers.hubspot.com/docs/methods/oauth2/using-access-tokens
It seems the old oAuth on the string is deprecated: http://developers.hubspot.com/docs/methods/auth/oauth-overview

Can you adjust to put this into the headers construction that gets passed in as a group? Moving up the auth params and updating comments? Plus removing the inclusion on the URL string itself as per the new docs?

@suhoij
Copy link
Author

suhoij commented Dec 7, 2016

@jzabel Sure. I could clean it up to correspond only the latest API.

@suhoij
Copy link
Author

suhoij commented Dec 8, 2016

@jzabel I've removed the authParams and moved the api_key to the finalParams. Also the comment was updated. Please, check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants