Add cache module #62
Open
Add cache module #62
+100
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed instances of .z.M and replaced `
di/cache/cache.q
Outdated
| if[0>requiredsize:(maxsize*MB) - size+sum exec size from cache; evict[neg requiredsize;now]]; | ||
| / Insert to the cache table | ||
| .z.M.cache upsert (id;now;now;size); | ||
| `cache upsert (id;now;now;size); |
Member
Author
There was a problem hiding this comment.
does this work as intended? i.e. it should not create/update a table cache in the root namespace, but within the module's private namespace
| perf:([]time:`timestamp$();id:`long$();status:`symbol$()); | ||
|
|
||
| id:0j; | ||
| getid:{:id+::1}; |
Contributor
There was a problem hiding this comment.
what is this doing? its not used anywhere else in this script.. i guess this begs the question is the id incrementation working as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work by @jcliffDI on cache module