-
Notifications
You must be signed in to change notification settings - Fork 165
test: add missing CI image to mirror #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Benchmarks [ tracer ]Benchmark execution time: 2025-12-09 12:08:19 Comparing candidate commit e20dc42 in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics. scenario:EmptyFileBench/benchEmptyFileDdprof-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
e20dc42 to
54da5c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3510 +/- ##
==========================================
- Coverage 61.75% 61.64% -0.11%
==========================================
Files 143 143
Lines 13008 13008
Branches 1702 1702
==========================================
- Hits 8033 8019 -14
- Misses 4215 4228 +13
- Partials 760 761 +1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Have we considered authenticating against Docker Hub to bypass (or widen) pull limits?
I am asking because this will add maintenance burden to us and we should be clear about that, if it's the case |
Indeed, this could be a much better solution under the condition that we have a Pro/Team/Business service account that we can use to do the authentication. In case we continue with that solution, we can just update those image when it cause an issue with the CI. |
Description
This PR modify our CI to use our private registry instead of dockerhub to pull the public images we are using.
The goal is to stop having image pull rate limits errors when we are running too many pipeline.