-
Notifications
You must be signed in to change notification settings - Fork 319
Only enable client side stats if the host agent is at least 7.65.0 #10041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088446
Total [baseline] (8.774 s) : 0, 8773736
Agent [candidate] (1.096 s) : 0, 1095790
Total [candidate] (8.776 s) : 0, 8776411
section iast
Agent [baseline] (1.219 s) : 0, 1218645
Total [baseline] (9.471 s) : 0, 9471333
Agent [candidate] (1.223 s) : 0, 1223074
Total [candidate] (9.453 s) : 0, 9453160
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (654.338 ms) : 0, 654338
BytebuddyAgent [candidate] (657.455 ms) : 0, 657455
GlobalTracer [baseline] (283.277 ms) : 0, 283277
GlobalTracer [candidate] (286.607 ms) : 0, 286607
AppSec [baseline] (32.456 ms) : 0, 32456
AppSec [candidate] (33.062 ms) : 0, 33062
Debugger [baseline] (67.906 ms) : 0, 67906
Debugger [candidate] (68.032 ms) : 0, 68032
Remote Config [baseline] (670.424 µs) : 0, 670
Remote Config [candidate] (694.371 µs) : 0, 694
Telemetry [baseline] (9.082 ms) : 0, 9082
Telemetry [candidate] (9.136 ms) : 0, 9136
Flare Poller [baseline] (3.715 ms) : 0, 3715
Flare Poller [candidate] (3.818 ms) : 0, 3818
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (787.882 ms) : 0, 787882
BytebuddyAgent [candidate] (791.251 ms) : 0, 791251
GlobalTracer [baseline] (255.074 ms) : 0, 255074
GlobalTracer [candidate] (255.796 ms) : 0, 255796
AppSec [baseline] (35.06 ms) : 0, 35060
AppSec [candidate] (35.431 ms) : 0, 35431
Debugger [baseline] (64.507 ms) : 0, 64507
Debugger [candidate] (64.666 ms) : 0, 64666
Remote Config [baseline] (541.295 µs) : 0, 541
Remote Config [candidate] (565.057 µs) : 0, 565
Telemetry [baseline] (8.408 ms) : 0, 8408
Telemetry [candidate] (8.408 ms) : 0, 8408
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.4 ms) : 0, 3400
IAST [baseline] (27.02 ms) : 0, 27020
IAST [candidate] (26.955 ms) : 0, 26955
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083130
Total [baseline] (10.794 s) : 0, 10793505
Agent [candidate] (1.081 s) : 0, 1081166
Total [candidate] (10.871 s) : 0, 10870900
section appsec
Agent [baseline] (1.272 s) : 0, 1272372
Total [baseline] (11.147 s) : 0, 11147142
Agent [candidate] (1.271 s) : 0, 1271376
Total [candidate] (11.12 s) : 0, 11119544
section iast
Agent [baseline] (1.222 s) : 0, 1221786
Total [baseline] (11.143 s) : 0, 11143187
Agent [candidate] (1.225 s) : 0, 1225238
Total [candidate] (11.141 s) : 0, 11140622
section profiling
Agent [baseline] (1.201 s) : 0, 1201227
Total [baseline] (11.003 s) : 0, 11003324
Agent [candidate] (1.203 s) : 0, 1202988
Total [candidate] (11.068 s) : 0, 11067638
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (650.432 ms) : 0, 650432
BytebuddyAgent [candidate] (648.295 ms) : 0, 648295
GlobalTracer [baseline] (281.967 ms) : 0, 281967
GlobalTracer [candidate] (282.23 ms) : 0, 282230
AppSec [baseline] (32.46 ms) : 0, 32460
AppSec [candidate] (32.341 ms) : 0, 32341
Debugger [baseline] (68.187 ms) : 0, 68187
Debugger [candidate] (68.251 ms) : 0, 68251
Remote Config [baseline] (647.196 µs) : 0, 647
Remote Config [candidate] (634.221 µs) : 0, 634
Telemetry [baseline] (9.031 ms) : 0, 9031
Telemetry [candidate] (8.969 ms) : 0, 8969
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.743 ms) : 0, 3743
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (694.878 ms) : 0, 694878
BytebuddyAgent [candidate] (693.493 ms) : 0, 693493
GlobalTracer [baseline] (260.6 ms) : 0, 260600
GlobalTracer [candidate] (260.651 ms) : 0, 260651
AppSec [baseline] (174.983 ms) : 0, 174983
AppSec [candidate] (174.634 ms) : 0, 174634
Debugger [baseline] (66.623 ms) : 0, 66623
Debugger [candidate] (67.429 ms) : 0, 67429
Remote Config [baseline] (697.711 µs) : 0, 698
Remote Config [candidate] (719.295 µs) : 0, 719
Telemetry [baseline] (8.902 ms) : 0, 8902
Telemetry [candidate] (8.93 ms) : 0, 8930
Flare Poller [baseline] (3.895 ms) : 0, 3895
Flare Poller [candidate] (3.85 ms) : 0, 3850
IAST [baseline] (24.903 ms) : 0, 24903
IAST [candidate] (24.874 ms) : 0, 24874
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (789.11 ms) : 0, 789110
BytebuddyAgent [candidate] (791.252 ms) : 0, 791252
GlobalTracer [baseline] (255.069 ms) : 0, 255069
GlobalTracer [candidate] (255.761 ms) : 0, 255761
AppSec [baseline] (34.506 ms) : 0, 34506
AppSec [candidate] (35.761 ms) : 0, 35761
Debugger [baseline] (66.962 ms) : 0, 66962
Debugger [candidate] (66.363 ms) : 0, 66363
Remote Config [baseline] (551.34 µs) : 0, 551
Remote Config [candidate] (561.682 µs) : 0, 562
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (8.453 ms) : 0, 8453
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.463 ms) : 0, 3463
IAST [baseline] (27.158 ms) : 0, 27158
IAST [candidate] (27.175 ms) : 0, 27175
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (699.9 ms) : 0, 699900
BytebuddyAgent [candidate] (700.357 ms) : 0, 700357
GlobalTracer [baseline] (220.521 ms) : 0, 220521
GlobalTracer [candidate] (220.674 ms) : 0, 220674
AppSec [baseline] (32.094 ms) : 0, 32094
AppSec [candidate] (32.299 ms) : 0, 32299
Debugger [baseline] (67.987 ms) : 0, 67987
Debugger [candidate] (68.084 ms) : 0, 68084
Remote Config [baseline] (626.555 µs) : 0, 627
Remote Config [candidate] (677.555 µs) : 0, 678
Telemetry [baseline] (8.929 ms) : 0, 8929
Telemetry [candidate] (8.998 ms) : 0, 8998
Flare Poller [baseline] (3.759 ms) : 0, 3759
Flare Poller [candidate] (3.798 ms) : 0, 3798
ProfilingAgent [baseline] (96.821 ms) : 0, 96821
ProfilingAgent [candidate] (97.36 ms) : 0, 97360
Profiling [baseline] (97.409 ms) : 0, 97409
Profiling [candidate] (97.925 ms) : 0, 97925
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1210
. : milestone, 1199,
iast (3.269 ms) : 3228, 3310
. : milestone, 3269,
iast_FULL (5.859 ms) : 5801, 5917
. : milestone, 5859,
iast_GLOBAL (3.641 ms) : 3582, 3699
. : milestone, 3641,
profiling (2.152 ms) : 2132, 2173
. : milestone, 2152,
tracing (1.823 ms) : 1807, 1840
. : milestone, 1823,
section candidate
no_agent (1.276 ms) : 1263, 1289
. : milestone, 1276,
iast (3.199 ms) : 3159, 3240
. : milestone, 3199,
iast_FULL (5.707 ms) : 5649, 5764
. : milestone, 5707,
iast_GLOBAL (3.599 ms) : 3547, 3651
. : milestone, 3599,
profiling (2.031 ms) : 2012, 2050
. : milestone, 2031,
tracing (1.84 ms) : 1825, 1855
. : milestone, 1840,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (19.364 ms) : 19165, 19564
. : milestone, 19364,
appsec (18.979 ms) : 18782, 19175
. : milestone, 18979,
code_origins (18.281 ms) : 18099, 18463
. : milestone, 18281,
iast (17.684 ms) : 17507, 17861
. : milestone, 17684,
profiling (18.881 ms) : 18691, 19071
. : milestone, 18881,
tracing (17.526 ms) : 17353, 17700
. : milestone, 17526,
section candidate
no_agent (18.899 ms) : 18706, 19092
. : milestone, 18899,
appsec (19.923 ms) : 19716, 20130
. : milestone, 19923,
code_origins (17.988 ms) : 17804, 18172
. : milestone, 17988,
iast (17.72 ms) : 17543, 17897
. : milestone, 17720,
profiling (19.572 ms) : 19373, 19772
. : milestone, 19572,
tracing (17.437 ms) : 17263, 17611
. : milestone, 17437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (3.683 ms) : 3468, 3898
. : milestone, 3683,
iast (2.232 ms) : 2167, 2296
. : milestone, 2232,
iast_GLOBAL (2.274 ms) : 2208, 2339
. : milestone, 2274,
profiling (2.5 ms) : 2338, 2663
. : milestone, 2500,
tracing (2.064 ms) : 2013, 2115
. : milestone, 2064,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.775 ms) : 3555, 3994
. : milestone, 3775,
iast (2.227 ms) : 2163, 2292
. : milestone, 2227,
iast_GLOBAL (2.274 ms) : 2209, 2339
. : milestone, 2274,
profiling (2.072 ms) : 2019, 2124
. : milestone, 2072,
tracing (2.063 ms) : 2012, 2113
. : milestone, 2063,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9c6d49693, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.217 s) : 18217000, 18217000
. : milestone, 18217000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
profiling (14.581 s) : 14581000, 14581000
. : milestone, 14581000,
tracing (14.553 s) : 14553000, 14553000
. : milestone, 14553000,
section candidate
no_agent (15.355 s) : 15355000, 15355000
. : milestone, 15355000,
appsec (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
iast (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (14.603 s) : 14603000, 14603000
. : milestone, 14603000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
|
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
35b0813 to
414bb53
Compare
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Show resolved
Hide resolved
414bb53 to
c08baa1
Compare
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
|
Currently blocked on system tests, because the test agent version is hardcoded to |
…-after-agent-7.65.0
| // Assumes the 'version' is below if it can't be parsed. | ||
| int majorDot = version.indexOf('.'); | ||
| if (majorDot == -1) { | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a potential mistake
shouldn't it be the opposite: custom agent builds would be assumed to be more recent. The comment at the top of the function describes it correctly
false otherwise (including when version is null or unparseable)
| */ | ||
| public static boolean isVersionBelow(String version, int maxMajor, int maxMinor, int maxPatch) { | ||
| if (version == null || version.isEmpty()) { | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as below
…-after-agent-7.65.0
What Does This Do
Only enable client side stats when the agent is at least 7.65.0.
Motivation
The reason is that container based primary tags are not supported by earlier versions of the host agent and as such can't be reported when CSS is enabled.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]