Fix publish workflow for release events #261
Open
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fix the publish workflow to correctly detect the branch name when triggered by a release event. Previously, when publishing from a release,
github.ref_namewould return the tag name (e.g.,v3.0.9) instead of the branch name, causing the branch validation to fail and preventing packages from being published to NPM.This was blocking releases as seen in https://github.com/DataDog/build-plugins/actions/runs/21300531101/job/61316867063
How?
releaseevents: usegithub.event.release.target_commitish(the branch the release was created from)workflow_dispatchevents: usegithub.ref_name(the branch from which the workflow was manually triggered)branch=$BRANCH) to avoid duplicating the detection logic