Apps plugin #254
Open
Apps plugin #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: bfccddc | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
yoannmoinet
force-pushed
the
yoann/apps-plugin
branch
from
1cae7b3 to
054f233
Compare
sdkennedy2
approved these changes
Jan 5, 2026
| log.error(red('Unable to determine the git remote to compute the app identifier.')); | ||
| } | ||
|
|
||
| const identifier = buildIdentifier(repository, name); |
There was a problem hiding this comment.
I wonder if we should be worried about conflicts when the repository url isn't defined and the package name conflicts across two apps. I don't think it needs to be solved now but maybe we should think through this scenario in one of the RFCs.
Member
Author
There was a problem hiding this comment.
Very good point, we could make it mandatory to have a remote url.
At least for now.
| const { errors: uploadErrors, warnings: uploadWarnings } = await uploadArchive( | ||
| archive, | ||
| { | ||
| apiKey: context.auth.apiKey, |
There was a problem hiding this comment.
Separately from the PR we should think through how we want to handle auth. I kind of like how dd-auth works.
Member
Author
There was a problem hiding this comment.
How does dd-auth work? (make it through DM in slack)
- defaultHeaders - createGzipFormData
yoannmoinet
force-pushed
the
yoann/apps-plugin
branch
from
fc4fabe to
c8d4f25
Compare
- Change form data fields from 'identifier'/'archive' to 'name'/'bundle' - Add name field to UploadContext type - Add name configuration option to AppsOptions - Update validation to handle name field Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Change resolveIdentifier to return { identifier, name } object
- Update main plugin to use config values with fallback to resolved values
- Only call resolveIdentifier if either value is missing
- Update error messages to mention both identifier and name
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update test context to include name field - Change assertions from identifier/archive to name/bundle - Update test description to reflect new field names Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update tests to expect { identifier, name } object
- Add assertions for both identifier and name fields
- Verify MD5 hash format for identifier and name value
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add 6 new test cases covering different name option scenarios: - Use name from config when provided (overrides resolved value) - Use identifier from config when provided (overrides resolved value) - Use both identifier and name from config (skips resolution) - Fail when only identifier provided but name cannot be resolved - Fail when only name provided but identifier cannot be resolved - Update integration test to include both identifier and name This ensures proper handling of all configuration combinations and validates that config values take precedence over resolved values. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add apps.name section to table of contents - Include name field in TypeScript configuration example - Document apps.name option with default value and usage - Explain when to use static name vs package.json name Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
appsplugin that zips built assets and uploads them to Datadog storage with optional dry-run and identifier override.appsplugin into the factory and published bundler packages while keeping alpha plugins hidden from the root README.How?
package.jsonor git remote (with sensitive info stripped)DATADOG_APPS_INTAKE_URL/DATADOG_SITE.createGzipFormDataandgetOriginHeadersfor compressed multipart requests and reuse them in sourcemap sending.hideFromRootReadme.