Skip to content

Conversation

@allspain
Copy link
Collaborator

@allspain allspain commented Dec 4, 2025

DO NOT MERGE THIS IS FOR A POC FOR INNOVATION WEEK

  • Introduced sendLiveDebuggerLog method to the RumPublicApi for sending log events.
  • Added configuration options for Firebase Remote Config integration, including allowLiveDebugger, liveDebuggerId, firebaseConfig, and firebaseVersion.
  • Updated the startRumEventCollection function to initialize Firebase Remote Config if enabled.

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

- Introduced `sendLiveDebuggerLog` method to the RumPublicApi for sending log events.
- Added configuration options for Firebase Remote Config integration, including `allowLiveDebugger`, `liveDebuggerId`, `firebaseConfig`, and `firebaseVersion`.
- Updated the `startRumEventCollection` function to initialize Firebase Remote Config if enabled.
@allspain allspain requested a review from a team as a code owner December 4, 2025 11:28
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 4, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.16 KiB 167.89 KiB +3.74 KiB +2.28%
Rum Profiler 4.84 KiB 4.84 KiB +1 B +0.02%
Rum Recorder 19.62 KiB 19.62 KiB +1 B +0.00%
Logs 55.96 KiB 56.05 KiB +86 B +0.15%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.42 KiB 125.08 KiB +3.66 KiB +3.01%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0053 0.0054 +1.89%
RUM - add action 0.0124 0.0145 +16.94%
RUM - add error 0.0113 0.0178 +57.52%
RUM - add timing 0.0027 0.0036 +33.33%
RUM - start view 0.0034 0.0036 +5.88%
RUM - start/stop session replay recording 0.0006 0.0008 +33.33%
Logs - log message 0.0126 0.019 +50.79%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.33 KiB 25.71 KiB -635 B
RUM - add action 49.31 KiB 92.61 KiB +43.30 KiB
RUM - add timing 24.20 KiB 23.97 KiB -236 B
RUM - add error 54.02 KiB 99.13 KiB +45.11 KiB
RUM - start/stop session replay recording 24.25 KiB 23.20 KiB -1.05 KiB
RUM - start view 423.76 KiB 431.90 KiB +8.14 KiB
Logs - log message 44.60 KiB 45.34 KiB +757 B

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Dec 4, 2025

⚠️ Tests

⚠️ Warnings

🧪 14 Tests failed

firebaseRemoteConfig startFirebaseRemoteConfigIntegration should listen to config updates from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog)
Error: Expected spy setContextProperty to have been called 2 times. It was called 1 times.
    at <Jasmine>
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/domain/liveDebugger/firebaseRemoteConfig.spec.ts:90:48 <- /tmp/_karma_webpack_55852/commons.js:231728:54)
firebaseRemoteConfig startFirebaseRemoteConfigIntegration should send log event on initialization from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog)
Expected spy setContextProperty to have been called with:
  [ 'dd_test-id-123', true ]
but it was never called.
Error: Expected spy setContextProperty to have been called with:
  [ 'dd_test-id-123', true ]
but it was never called.
    at <Jasmine>
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/domain/liveDebugger/firebaseRemoteConfig.spec.ts:65:48 <- /tmp/_karma_webpack_55852/commons.js:231709:54)
firebaseRemoteConfig startFirebaseRemoteConfigIntegration should set global context property with dd_ format on init from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog)
Expected spy setContextProperty to have been called with:
  [ 'dd_test-id-123', true ]
but it was never called.
Error: Expected spy setContextProperty to have been called with:
  [ 'dd_test-id-123', true ]
but it was never called.
    at <Jasmine>
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/domain/liveDebugger/firebaseRemoteConfig.spec.ts:53:48 <- /tmp/_karma_webpack_55852/commons.js:231700:54)
View all

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 34.75%
Total Coverage: 91.69% (-0.94%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: edebf79 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

removed * from .gitignore and add new lines in liveDebuggerLogger files for consistency
@github-actions
Copy link

github-actions bot commented Dec 5, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

… submission

- Added `sendRawLog` method to the `LogsPublicApi`, allowing logs to be sent directly to the `LOG_COLLECTED` lifecycle event, bypassing the assembly step.
- Enhanced the `liveDebug` function in the live debugger to match the `dd-trace-js` send method signature, enabling structured log submissions.
- Updated tests to verify the functionality of the new logging methods and ensure proper payload construction.
- Updated the `liveDebug` function to include the application ID from the RUM internal context, improving log context.
- Modified the live debugger test configuration to specify a service name for better log categorization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants