Add showErrorStrategy config option for submission form #4931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config option submission.showErrorStrategy is of type ShowErrorStrategy, which can be 'onblur' or 'onload'. The default is 'onblur', which will show errors only after clicking an input field.
This PR was provided by The Library Code with the support of FHNW.
References
Description
This PR adds a config option for submission forms to show validation errors on form load. The default strategy, 'onblur', is kept consistent with current behavior.
Instructions for Reviewers
List of changes in this PR:
src/app/submission/form/submission-form.component.tsAdd the option to the
config/config.yml, and test to see that form errors are displayed on form load, not on form input field blur.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint(with existing errors)
npm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.