Skip to content

Conversation

@strawburster
Copy link

@strawburster strawburster commented Dec 9, 2025

Config option submission.showErrorStrategy is of type ShowErrorStrategy, which can be 'onblur' or 'onload'. The default is 'onblur', which will show errors only after clicking an input field.

This PR was provided by The Library Code with the support of FHNW.

References

Description

This PR adds a config option for submission forms to show validation errors on form load. The default strategy, 'onblur', is kept consistent with current behavior.

Instructions for Reviewers

List of changes in this PR:

  • Add new submission config option 'showErrorStrategy'
  • Use submission config option in src/app/submission/form/submission-form.component.ts

Add the option to the config/config.yml, and test to see that form errors are displayed on form load, not on form input field blur.

rest:
  ssl: true
  host: sandbox.dspace.org
  port: 443
  nameSpace: /server
submission:
  showErrorStrategy: 'onload'

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
    (with existing errors)
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • [na] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [na] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [na] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [na] If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added improvement component: submission 1 APPROVAL pull request only requires a single approval to merge labels Dec 10, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Dec 10, 2025
showErrorStrategy is of type ShowErrorStrategy, which can be 'onblur'
or 'onload'. The default is 'onblur', which will show errors only
after clicking an input field.
@strawburster strawburster force-pushed the config-show-form-errors branch from 406a3d0 to 954b4aa Compare December 11, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: submission improvement

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants