Skip to content

Conversation

@jesielviana
Copy link
Contributor

References

Description

This PR implements a PDF viewer based on the work of @juangarcia-Cultura described in issue
The PDF viewer is disabled by default and must be explicitly enabled in the configuration to be displayed.
Additionally, the media viewer has been placed on the main content page, positioned above the geolocation viewer.

Instructions for Reviewers

To test the PDF viewer:

  1. Enable the PDF media viewer in the configuration settings.
  2. Open an item or publication entity that contains one or more PDF files.
  3. Verify that the PDF viewer is displayed on the screen and renders the files correctly.

List of changes in this PR:

  • Implemented a new PDF viewer using the native browser <object> tag instead of ng2-pdfjs-viewer.
  • Integrated the viewer into the main content page, above the geolocation viewer.
  • Made the PDF viewer configurable and disabled by default.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@jesielviana jesielviana marked this pull request as draft December 8, 2025 15:58
@jesielviana jesielviana marked this pull request as ready for review December 9, 2025 16:30
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Dec 10, 2025
@tdonohue tdonohue added the component: viewer Related to media viewers / inline streaming of content label Dec 10, 2025
Copy link

@jrcwiok jrcwiok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Enable the PDF media viewer in the configuration settings.
  • Open an item or publication entity that contains one or more PDF files
  • Verify that the PDF viewer is displayed on the screen and renders the files correctly.
Screenshot 2025-12-19 at 09 28 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: viewer Related to media viewers / inline streaming of content new feature

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

4 participants