Improvement: Make FORTRAN interface work again and add tests for all its functions#2177
Open
Improvement: Make FORTRAN interface work again and add tests for all its functions#2177
Conversation
Davknapp
requested changes
Feb 10, 2026
| void | ||
| t8_fortran_cmesh_commit (t8_cmesh_t cmesh, sc_MPI_Comm *comm); | ||
|
|
||
| /** This function calls t8_cmesh_set_join_by_stash with connectivity = NULL. |
Collaborator
There was a problem hiding this comment.
Why did you delete this function?
| !! | ||
| !! This program tests if the cmesh part of the Fortran | ||
| !! interface can be called. | ||
| !! Works only when MPI is enabled. |
Collaborator
There was a problem hiding this comment.
What happens if MPI is disabled and this test is called?
|
|
||
| !! Description: | ||
| !! | ||
| !! This program tests if the cmesh part of the Fortran |
Collaborator
There was a problem hiding this comment.
Can you elaborate a little bit more (e.g. it create a cmesh and writes it....)
| !! t8code is a C library to manage a collection (a forest) of multiple | ||
| !! connected adaptive space-trees of general element classes in parallel. | ||
| !! | ||
| !! Copyright (C) 2024 the developers |
Collaborator
There was a problem hiding this comment.
Suggested change
| !! Copyright (C) 2024 the developers | |
| !! Copyright (C) 2026 the developers |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2177 +/- ##
==========================================
+ Coverage 77.97% 78.31% +0.33%
==========================================
Files 113 115 +2
Lines 19106 19119 +13
==========================================
+ Hits 14898 14973 +75
+ Misses 4208 4146 -62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1816
Closes #1811
Describe your changes here:
For improved readability, this PR replaces #1815. It improves the FORTRAN interface by
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).