-
Notifications
You must be signed in to change notification settings - Fork 10
ci: convert daily e2e test to weekly #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be3204b to
db1d13a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
0c219a7 to
7085fa6
Compare
87a3376 to
1a91ba1
Compare
ed68882 to
494fd76
Compare
b59be84 to
8b96b41
Compare
8b96b41 to
e219e66
Compare
| --verbose \ | ||
| > /tmp/blc_output.txt 2>&1 | ||
| blc_exit_code=$? | ||
| set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Captured blc exit code is never checked
The comment on line 51 says "Don't exit on blc failure, we'll handle it" and blc_exit_code is captured on line 61, but this variable is never actually used. If blc completely fails to run (crashes, network issues, etc.), the output file will be empty or contain only error messages, the grep for broken links will find nothing, and the workflow will incorrectly report success ("All links verified successfully") even though the link check never completed.
- This is because curl cannot truncate /dev/null on retry attempts, causing "Failed to truncate file" errors. Use mktemp file instead and clean up after.
f743036 to
85bbcde
Compare
Note
Refines broken-link check workflow with rate-limited verification and narrows triggers, and changes E2E schedule to run weekly on Sundays.
/.github/workflows/broken-link-checker.yml:pull_requestandpushonmain,master,develop.blcrate-limiting options (--ordered,--get,--user-agent,--host-requests 1,--recursive,--verbose).blcoutput, extracts├─BROKEN─entries, and verifies each withcurl(retries, timeouts)./.github/workflows/cypress_prod.yml:Written by Cursor Bugbot for commit 85bbcde. This will update automatically on new commits. Configure here.