Skip to content

Conversation

@yinanazhou
Copy link
Member

@yinanazhou yinanazhou commented Nov 28, 2025

Note

Refines broken-link check workflow with rate-limited verification and narrows triggers, and changes E2E schedule to run weekly on Sundays.

  • CI Workflows:
    • /.github/workflows/broken-link-checker.yml:
      • Refines triggers to pull_request and push on main, master, develop.
      • Replaces ad-hoc retry logic with blc rate-limiting options (--ordered, --get, --user-agent, --host-requests 1, --recursive, --verbose).
      • Captures and displays blc output, extracts ├─BROKEN─ entries, and verifies each with curl (retries, timeouts).
      • Treats HTTP 429 as non-failing; fails CI only for verified bad links; clearer pass/fail summaries.
    • /.github/workflows/cypress_prod.yml:
      • Changes schedule from daily to weekly (Sunday) via cron update.

Written by Cursor Bugbot for commit 85bbcde. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@yinanazhou yinanazhou force-pushed the weekly-job branch 2 times, most recently from 87a3376 to 1a91ba1 Compare November 30, 2025 22:44
@yinanazhou yinanazhou force-pushed the weekly-job branch 4 times, most recently from ed68882 to 494fd76 Compare November 30, 2025 23:39
@yinanazhou yinanazhou force-pushed the weekly-job branch 5 times, most recently from b59be84 to 8b96b41 Compare December 4, 2025 02:38
--verbose \
> /tmp/blc_output.txt 2>&1
blc_exit_code=$?
set -e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Captured blc exit code is never checked

The comment on line 51 says "Don't exit on blc failure, we'll handle it" and blc_exit_code is captured on line 61, but this variable is never actually used. If blc completely fails to run (crashes, network issues, etc.), the output file will be empty or contain only error messages, the grep for broken links will find nothing, and the workflow will incorrectly report success ("All links verified successfully") even though the link check never completed.

Fix in Cursor Fix in Web

- This is because curl cannot truncate /dev/null on retry attempts, causing "Failed to truncate file" errors. Use mktemp file instead and clean up after.
@yinanazhou yinanazhou merged commit 09b01b9 into develop Dec 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants