Add only contour plot feature#222
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 78.39% 77.32% -1.08%
==========================================
Files 67 67
Lines 7671 7681 +10
==========================================
- Hits 6014 5939 -75
- Misses 1657 1742 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi Paul, |
Yes, please add two tests:
|
…jangi/DCscope into add_only_contour_plot_feature
|
Hi Paul, |
paulmueller
left a comment
paulmueller
left a comment
There was a problem hiding this comment.
Just a few minor things to harden the tests.
tests/test_gui_plotting.py
Outdated
| # Verify that zoom was applied | ||
| assert np.all(np.isfinite(x_range)) | ||
| assert np.all(np.isfinite(y_range)) | ||
| assert x_range[0] != 0 or x_range[1] != 1 |
There was a problem hiding this comment.
Please test for actual values of the range (the zoomed-in values). A future regression might pass this test even though it breaks the functionality.
tests/test_gui_plotting.py
Outdated
| # Set contour percentiles to extreme values (edge cases) | ||
| # 100% percentile is at the maximum KDE value | ||
| pv.doubleSpinBox_perc_1.setValue(100.0) # Maximum percentile | ||
| pv.doubleSpinBox_perc_2.setValue(99.0) # Near maximum |
There was a problem hiding this comment.
Please set the second level to 100% as well. The test is about catching error messages when nonsense is plotted.
|
|
||
| # Get the plot state | ||
| plot_state = mw.pipeline.get_plot(plot_id).__getstate__() | ||
|
|
There was a problem hiding this comment.
Please add an assert that makes sure there is only one plot.
|
Hi Paul, |
2 participants
This PR aims to implement issue #210