Conversation
|
Please add one release label: |
|
OK, so the tricky thing about making updates to so you need to update this PR to also include |
johnny-hausman
left a comment
There was a problem hiding this comment.
There is also a lot of additional code in the ABViewLabelCore file that should end up in there too ...
| * @return {string} plugin key | ||
| */ | ||
| static getPluginKey() { | ||
| return "ab-view-view-label"; |
There was a problem hiding this comment.
If you are wanting this Plugin to REPLACE the original ABViewLabel object we had, then this method should return the same key ( "label" ) as the original.
My current version of the ab-cli will simply put:
static getPluginKey() {
return this.common().key;
}
For this method so it matches the one it is replacing.
Lighthouse Performance ReportMetrics📄Full Report |
No description provided.