Skip to content

update plugin view label#693

Draft
roguisharcanetrickster wants to merge 5 commits intomasterfrom
rat/label
Draft

update plugin view label#693
roguisharcanetrickster wants to merge 5 commits intomasterfrom
rat/label

Conversation

@roguisharcanetrickster
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Please add one release label:
major (for breaking changes), minor (for new features), patch (for bug fixes) or skip-release (to skip the auto release process).

@roguisharcanetrickster roguisharcanetrickster added the minor Tag Pull Requests to trigger a minor version update label Feb 17, 2026
@johnny-hausman
Copy link
Collaborator

OK, so the tricky thing about making updates to ab_platform_web when what you currently have also depends on changes to the core code, is that you also have to make ab_platform_web's core point to the branch you updated on core.

so you need to update this PR to also include core#rat/plugin_label and that should stop the core from trying to reference these files you just removed.

Copy link
Collaborator

@johnny-hausman johnny-hausman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a lot of additional code in the ABViewLabelCore file that should end up in there too ...

* @return {string} plugin key
*/
static getPluginKey() {
return "ab-view-view-label";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are wanting this Plugin to REPLACE the original ABViewLabel object we had, then this method should return the same key ( "label" ) as the original.

My current version of the ab-cli will simply put:

      static getPluginKey() {
         return this.common().key;
      }

For this method so it matches the one it is replacing.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

Lighthouse Performance Report

Metrics





📄Full Report
Note: Above values are an average of 3 reports, only the last report was uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Tag Pull Requests to trigger a minor version update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments