Add node label validation to prevent command injection (#251) #276
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinxshKD
force-pushed
the
fix-command-injection-251
branch
from
a478003 to
e0b44ee
Compare
Author
|
@pradeeban Rebased on dev. The safe_name() fix is already there, so I added CLI-level validation for better UX. Test passes with no conflicts thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev branch already has safe_name() validation for this. Added the same check to CLI validate so users catch bad labels earlier instead of at runtime.
Added test for shell metacharacters in node labels.
fixes #251