refactor: use environment config for API base URL#289
Closed
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Closed
refactor: use environment config for API base URL#289avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Conversation
Member
|
Merge conflict here too... |
Member
|
Resolving the merge conflict has given a PR with zero changes. Perhaps a merged PR has already implemented what you are trying to do here? |
Author
|
@pradeeban You’re right this PR became zero-diff because the same fix was already merged in #290 now due to conflicts, and I’ve closed this PR to avoid duplicate work |
Member
|
Funny. |
Author
|
Haha looks like I set up a race and still managed second place. Funniest thing happened me on here 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the hardcoded http://127.0.0.1:5000 into a configurable constant that reads from process.env.REACT_APP_API_BASE_URL, making it easier to deploy the frontend against different backend environments.
Fixes #272
Changes:
Added API_BASE_URL constant to config.js with env var fallback
Replaced hardcoded URLs in 6-server.js (7 occurrences)
Replaced hardcoded URL in ContributeDetails.jsx (1 occurrence)