Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Nov 25, 2025

Summary

  • update @comfyorg/desktop-ui dependency to 0.0.4
  • pin the package version to the new release

Testing

  • not run (not requested)

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner November 25, 2025 21:51
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 25, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

📝 Walkthrough

Walkthrough

Updated the @comfyorg/desktop-ui dependency in package.json to an exact version and changed the Windows E2E GitHub Actions workflow concurrency group to a dedicated windows-e2e group using the PR number (with fallback), isolating Windows runs for cancel-in-progress behavior.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
package.json
Updated @comfyorg/desktop-ui from ^0.0.3 to 0.0.4, removing the caret to pin an exact version.
Windows E2E Workflow Concurrency
.github/workflows/integration_test_windows.yml
Reworked concurrency group to `windows-e2e-${{ github.event.pull_request.number

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant PR as Pull Request
  participant GH as GitHub Actions
  participant Runner as Windows Runner
  participant Concurrency as Concurrency Group

  Note over PR,GH: Old flow (before change)
  PR->>GH: trigger windows integration workflow
  GH->>Concurrency: compute group using workflow_ref + ref
  Concurrency-->>GH: group id (shared across workflows)
  GH->>Runner: start job (may be canceled if group matches)
  Runner-->>GH: run/complete

  Note over PR,GH: New flow (after change)
  PR->>GH: trigger windows integration workflow
  GH->>Concurrency: compute group "windows-e2e-${{PR.number || ref}}"
  Concurrency-->>GH: windows-e2e scoped group id
  GH->>Runner: start job (cancel-in-progress applies per-windows group)
  Runner-->>GH: run/complete
Loading
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump/desktop-ui-0.0.4

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the dependencies label Nov 25, 2025
@socket-security
Copy link

socket-security bot commented Nov 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​comfyorg/​desktop-ui@​0.0.3 ⏵ 0.0.480 +210074 +292 +170

View full report

@benceruleanlu benceruleanlu requested a review from a team as a code owner November 25, 2025 21:59
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c6d3af and 16a2bf3.

📒 Files selected for processing (1)
  • .github/workflows/integration_test_windows.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.063Z
Learning: Consider running `yarn test:e2e` for UI changes before committing.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: lint-and-format (macos-latest)
  • GitHub Check: lint-and-format (windows-latest)
  • GitHub Check: build-and-test-e2e-windows / integration-windows-test
  • GitHub Check: build-apple-debug-all / build-macos-debug
🔇 Additional comments (1)
.github/workflows/integration_test_windows.yml (1)

7-9: Technical implementation of concurrency isolation is sound.

The concurrency group logic is well-structured:

  • windows-e2e prefix clearly isolates Windows runs from other workflow concurrency groups
  • PR number fallback to git ref is appropriate for both pull request and workflow_dispatch contexts
  • The explanatory comment (line 7) clearly documents the intent to prevent unwanted cancellations

Since this workflow is triggered via workflow_dispatch and workflow_call (not direct PR events), the fallback to github.ref ensures the concurrency group has a valid identifier in all contexts.

If this change is intentional, please verify that Windows E2E test runs are no longer unexpectedly canceled by top-level workflow concurrency, especially during concurrent PR testing.

@benceruleanlu benceruleanlu merged commit 0631afa into main Nov 25, 2025
5 of 7 checks passed
@benceruleanlu benceruleanlu deleted the bump/desktop-ui-0.0.4 branch November 25, 2025 23:08
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants