-
Notifications
You must be signed in to change notification settings - Fork 177
chore: bump desktop-ui to 0.0.4 #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdated the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant PR as Pull Request
participant GH as GitHub Actions
participant Runner as Windows Runner
participant Concurrency as Concurrency Group
Note over PR,GH: Old flow (before change)
PR->>GH: trigger windows integration workflow
GH->>Concurrency: compute group using workflow_ref + ref
Concurrency-->>GH: group id (shared across workflows)
GH->>Runner: start job (may be canceled if group matches)
Runner-->>GH: run/complete
Note over PR,GH: New flow (after change)
PR->>GH: trigger windows integration workflow
GH->>Concurrency: compute group "windows-e2e-${{PR.number || ref}}"
Concurrency-->>GH: windows-e2e scoped group id
GH->>Runner: start job (cancel-in-progress applies per-windows group)
Runner-->>GH: run/complete
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/integration_test_windows.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/desktop PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T20:49:28.063Z
Learning: Consider running `yarn test:e2e` for UI changes before committing.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format (macos-latest)
- GitHub Check: lint-and-format (windows-latest)
- GitHub Check: build-and-test-e2e-windows / integration-windows-test
- GitHub Check: build-apple-debug-all / build-macos-debug
🔇 Additional comments (1)
.github/workflows/integration_test_windows.yml (1)
7-9: Technical implementation of concurrency isolation is sound.The concurrency group logic is well-structured:
windows-e2eprefix clearly isolates Windows runs from other workflow concurrency groups- PR number fallback to git ref is appropriate for both pull request and workflow_dispatch contexts
- The explanatory comment (line 7) clearly documents the intent to prevent unwanted cancellations
Since this workflow is triggered via
workflow_dispatchandworkflow_call(not direct PR events), the fallback togithub.refensures the concurrency group has a valid identifier in all contexts.If this change is intentional, please verify that Windows E2E test runs are no longer unexpectedly canceled by top-level workflow concurrency, especially during concurrent PR testing.
This reverts commit 16a2bf3.
Summary
Testing
┆Issue is synchronized with this Notion page by Unito