-
-
Notifications
You must be signed in to change notification settings - Fork 303
Input Improvements & Fixes #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
i thought i already fixed the clipRect issues for sustains being 1 frame late? |
No, at least not in the latest commit I tested. I had confirmed the issue still existed before I started working on it. |
|
:0 |
|
looks good to me |
|
ill make some changes so you can have the legacy sustains with Flag |
COOL |
|
Alright, given that there's been no activity for quite some time, I went ahead and added |
|
@Raltyro Check |
|
Oh |
Raltyro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gameplay Changes should not be an option for player, instead its should be a flag for a modpack to configure, and i honestly think one sustain in note can be on as default
👌 |
|
OK, the corrections are done. |
Fixed Issues
clipRectissue reported on DiscordRoot cause: Sustain hit detection required 1-frame delay for proper judgment
Sustain Behavior Changes
Technical Notes