Skip to content

Conversation

@HEIHUAa
Copy link
Contributor

@HEIHUAa HEIHUAa commented Nov 26, 2025

Fixed Issues

  • Resolved clipRect issue reported on Discord
    Root cause: Sustain hit detection required 1-frame delay for proper judgment

Sustain Behavior Changes

  • Unified sustain mechanics - Now functions as a continuous note segment
  • Single miss penalty - Entire sustain segment counts as one miss (0.0475 × 4 health deduction)
    • Rationale: Average player reaction time ≈ 4 sustain notes during miss
  • Cascade protection - Missing any sustain now disables subsequent sustains in chain
    • Previous: Misses didn't interrupt following sustains
    • Current: Missed sustains block further input & avoid penalty stacking

Technical Notes

  • Frame-perfect input handling restored
  • Health deduction values rebalanced for rhythm accuracy
  • Sustain visualization matches gameplay behavior

@Raltyro
Copy link
Member

Raltyro commented Nov 26, 2025

i thought i already fixed the clipRect issues for sustains being 1 frame late?

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Nov 26, 2025

i thought i already fixed the clipRect issues for sustains being 1 frame late?

No, at least not in the latest commit I tested. I had confirmed the issue still existed before I started working on it.

@Raltyro Raltyro requested a review from NexIsDumb November 26, 2025 13:28
@NexIsDumb
Copy link
Member

:0
imma check these days

@Raltyro
Copy link
Member

Raltyro commented Nov 29, 2025

looks good to me

@Raltyro
Copy link
Member

Raltyro commented Nov 29, 2025

ill make some changes so you can have the legacy sustains with Flag

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Nov 30, 2025

ill make some changes so you can have the legacy sustains with Flag

COOL

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Dec 13, 2025

Alright, given that there's been no activity for quite some time, I went ahead and added Options.sustainsAsOneNote and implemented it on the settings page.

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Dec 13, 2025

@Raltyro Check

@HEIHUAa HEIHUAa requested a review from Raltyro December 13, 2025 06:45
@Raltyro
Copy link
Member

Raltyro commented Dec 13, 2025

Oh

Copy link
Member

@Raltyro Raltyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gameplay Changes should not be an option for player, instead its should be a flag for a modpack to configure, and i honestly think one sustain in note can be on as default

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Dec 13, 2025

Gameplay Changes should not be an option for player, instead its should be a flag for a modpack to configure, and i honestly think one sustain in note can be on as default

👌

@HEIHUAa
Copy link
Contributor Author

HEIHUAa commented Dec 13, 2025

OK, the corrections are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants