Fix Start9 set-config.sh stdin consumption bug#21
Merged
Conversation
The set-config.sh scripts were attempting to read from stdin twice: 1. First with `cat` to capture JSON configuration 2. Then again in Python with `json.load(sys.stdin)` This caused the Python script to receive empty input, resulting in "Expecting value: line 1 column 1" JSON parsing errors. Changes: - Export CONFIG_JSON as environment variable - Read JSON from environment in Python using json.loads() - Remove redundant bash grep parsing code - Add quotes to heredoc delimiter to prevent variable expansion This fix applies to both: - start9/set-config.sh (main script) - start9/scripts/set-config.sh (alternate location) Tested with sample configuration and verified .env file generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set-config.sh scripts were attempting to read from stdin twice:
catto capture JSON configurationjson.load(sys.stdin)This caused the Python script to receive empty input, resulting in "Expecting value: line 1 column 1" JSON parsing errors.
Changes:
This fix applies to both:
Tested with sample configuration and verified .env file generation.