Add permissions and trigger on fix branches #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the GitHub Actions workflow to run on fix/* branches, elevates workflow permissions, and marks published releases as prereleases.
- Expanded
pull_requesttrigger to includefix/*branches - Added
contents: writeandpackages: writepermissions - Changed
prereleaseflag fromfalsetotruefor releases
Comments suppressed due to low confidence (3)
.github/workflows/dotnet-desktop.yml:18
- Consider adding a comment explaining the inclusion of the 'fix/*' pattern to clarify which branches should trigger the workflow and prevent unintended matches.
branches: [ "main", "fix/*" ]
.github/workflows/dotnet-desktop.yml:157
- Update your project’s release documentation or change log to reflect that new releases will now be marked as prereleases, ensuring consumers understand this update.
prerelease: true
.github/workflows/dotnet-desktop.yml:20
- Review the granted permissions to follow the principle of least privilege; if 'contents: write' is not strictly required, consider limiting or removing it to reduce risk.
permissions:
… release conditions accordingly
Change the conditional running of the release steps to also check head_ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.