LDAP Module #869
LDAP Module #869
Conversation
robin-checkmk
force-pushed
the
feature/ldap_module
branch
from
b9acae1 to
fcb1044
Compare
robin-checkmk
force-pushed
the
feature/ldap_module
branch
from
5a1991f to
95e20db
Compare
robin-checkmk
left a comment
robin-checkmk
left a comment
There was a problem hiding this comment.
I never submitted my comments. 🤦
@lgetwan you could never see these comments. I think the first two are obsolete, but we should probably discuss the last one.
| register: __checkmk_var_result_create | ||
| failed_when: __checkmk_var_result_create.changed | bool | ||
|
|
||
| - name: "{{ outer_item.version }} - {{ outer_item.edition | upper }} - Lookup an LDAP connection." |
There was a problem hiding this comment.
I am uncertain, if we should mix the lookup module tests and the module tests.
I see, why we use the lookup here and it makes perfect sense. The issue I have, that with this layout, we cannot trigger tests for the lookup modules and the module separately. And that could trigger some weird cross-dependencies. It is not terrible, but something to consider for sure.
| # api_auth_type = self.get_option("api_auth_type") or "bearer" | ||
| # api_auth_cookie = self.get_option("api_auth_cookie") | ||
| automation_user = self.get_option("automation_user") | ||
| automation_secret = self.get_option("automation_secret") |
There was a problem hiding this comment.
I 'fixed' the authentication options, so the tests do not fail anymore, but with the api_ variables I got other errors, so I am certainly missing something here.
| # api_auth_type=api_auth_type, | ||
| # api_auth_cookie=api_auth_cookie, | ||
| automation_user=automation_user, | ||
| automation_secret=automation_secret, |
There was a problem hiding this comment.
I 'fixed' the authentication options, so the tests do not fail anymore, but with the api_ variables I got other errors, so I am certainly missing something here.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Since 2.4.0, the REST API has LDAP connections endpoints, but there was no LDAP module in the collection.
What is the new behavior?
Now there is an LDAP module and two lookup modules (LDAP connection & LDAP connections).