Skip to content

Increase timeout to 10s for flaky 3D tileset spec #13061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Beilinson wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −4
Open

Increase timeout to 10s for flaky 3D tileset spec #13061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7b6c9
Increase timeout to 10s for flaky 3D tileset spec
Beilinson Nov 27, 2025
72ffef2
Add timeout to the poller as well
Beilinson Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Specs/Cesium3DTilesTester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,13 @@ Cesium3DTilesTester.expectRenderTileset = function (scene, tileset) {
};

Cesium3DTilesTester.waitForTilesLoaded = function (scene, tileset) {
return pollToPromise(function () {
scene.renderForSpecs();
return tileset.tilesLoaded;
}).then(function () {
return pollToPromise(
function () {
scene.renderForSpecs();
return tileset.tilesLoaded;
},
{ timeout: 10000 },
).then(function () {
scene.renderForSpecs();
return tileset;
});
Expand Down
4 changes: 4 additions & 0 deletions packages/engine/Specs/Scene/Cesium3DTilesetSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ import generateJsonBuffer from "../../../../Specs/generateJsonBuffer.js";
import pollToPromise from "../../../../Specs/pollToPromise.js";
import Ellipsoid from "../../Source/Core/Ellipsoid.js";

const JASMINE_DEFAULT_TIMEOUT = jasmine.DEFAULT_TIMEOUT_INTERVAL;

describe(
"Scene/Cesium3DTileset",
function () {
Expand Down Expand Up @@ -204,6 +206,7 @@ describe(
});

beforeEach(function () {
jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;
RequestScheduler.clearForSpecs();
scene.morphTo3D(0.0);

Expand All @@ -221,6 +224,7 @@ describe(
});

afterEach(function () {
jasmine.DEFAULT_TIMEOUT_INTERVAL = JASMINE_DEFAULT_TIMEOUT;
scene.verticalExaggeration = 1.0;
scene.primitives.removeAll();
ResourceCache.clearForSpecs();
Expand Down