ENH: Disable unnecessary compression support in LLVM build configuration #80
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration The value of 10.11 was hard-coded for the external project build, but was not exposed at the SuperBuild level. This change makes the setting of the OSX_DEPLOYMENT_TARGET more transparent.
CMake building of llvm autodetects zstd and zlib from homebrew and automatically links against them. A compiler warning is given: ``` ld: warning: building for macOS-11.0, but linking with dylib '/opt/homebrew/opt/zstd/lib/libzstd.1.dylib' which was built for newer version 15.0 ``` Additionally, this prevents castxml from running on many systems due to the dependence on homebrew being installed with the same or newer version as was present during compilation.
Contributor
Author
otool -L ./clang-prefix/src/clang-build/lib/libclang-cpp.dylib
./clang-prefix/src/clang-build/lib/libclang-cpp.dylib:
@rpath/libclang-cpp.dylib (compatibility version 0.0.0, current version 0.0.0)
/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1226.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1356.0.0)
\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/
/opt/homebrew/opt/zstd/lib/libzstd.1.dylib (compatibility version 1.0.0, current version 1.5.7)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #undesirable dependency was automatically added.
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.12)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #This is probably OK, but also not needed, so remove.
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 2000.67.0)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 4201.0.0) |
Contributor
Author
|
@thewtex This addresses an issue that was described with castxml on macs as being linked to homebrew zstd and zlib. This PR removes the unnecessary dependencies by disabling both ZSTD and ZLIB support. |
thewtex
reviewed
Dec 22, 2025
|
|
||
|
|
||
| if(APPLE) | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "Set the minimum supported OSX target" FORCE) |
Contributor
There was a problem hiding this comment.
I don't think we want FORCE here
| endif() | ||
| # 2025-12-11 master | ||
| set(CastXML_GIT_TAG bca6af13daf298f6d63bf2e4d4488c11c7e99b22 CACHE STRING "CastXML Git revision.") | ||
| set(CastXML_GIT_TAG "216-Followup-MSVC-fix" CACHE STRING "CastXML Git revision." FORCE) |
Contributor
There was a problem hiding this comment.
I don't think we want FORCE here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake building of llvm autodetects zstd and zlib from homebrew and automatically links against them.