Skip to content

WIP DO NOT MERGE ENH: Update CastXML to fix MSVC Stack size issue #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hjmjohnson wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP DO NOT MERGE ENH: Update CastXML to fix MSVC Stack size issue #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d33a3
WIP: DO NOT COMMIT. Test against outstanding PR.
hjmjohnson Dec 19, 2025
84dd6a4
test: exclude fbracket-depth that is incompatible with github CI
hjmjohnson Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,16 @@ jobs:

#####################################
# [Optional] Run Tests
# NOTE: -LE LargeStackRequired is used to skip
# running tests on GitHub CI environment that
# has limited stack allowed.
# The fbracket-depth passes outside of GitHub
# but fails inside Github CI
#####################################
- name: Test
run: |
cd build/castxml-prefix/src/castxml-build
ctest --output-on-failure
ctest --output-on-failure -LE LargeStackRequired

#####################################
# Package the resulting castxml binary
Expand Down
6 changes: 4 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,11 @@ if(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_SYSTEM_NAME MATCHES "Linux")
set(linux_args "-DCMAKE_CXX_FLAGS:STRING=-static-libstdc++")
endif()
# 2025-12-11 master
set(CastXML_GIT_TAG bca6af13daf298f6d63bf2e4d4488c11c7e99b22 CACHE STRING "CastXML Git revision.")
set(CastXML_GIT_TAG "216-Followup-MSVC-fix" CACHE STRING "CastXML Git revision." FORCE)
ExternalProject_Add(castxml
GIT_REPOSITORY https://github.com/CastXML/CastXML.git
#GIT_REPOSITORY https://github.com/CastXML/CastXML.git
# WIP DO NOT COMMIT UNITL AFTER https://github.com/CastXML/CastXML/pull/295 is incorporated.
GIT_REPOSITORY https://github.com/hjmjohnson/CastXML.git
GIT_TAG ${CastXML_GIT_TAG}
DEPENDS ${castxml_deps}
CMAKE_ARGS -Wno-dev
Expand Down
Loading