Skip to content

Conversation

@hjmjohnson
Copy link

Followup on commit 5f551bd to ensure that the stack size linkage flag is respected.

Github CI appears to have a smaller default stack size than typical MSVC environments.

  1. Flag should be /STACK:### instead of -STACK:###

  2. The test cmd.fbracket-depth can be forced to fail by setting
    CMAKE_EXE_LINKER_FLAGS to /STACK:100

  3. Additionally, CMAKE_EXE_LINKER_FLAGS needs to be set with CACHE
    for the value to persist into the CMakeCache.txt. Without set(CACHE)
    statement, the CMakeCache.txt did not include the requested
    /STACK:###

@hjmjohnson
Copy link
Author

@thewtex @bradking

I think this fix to CastXML will fix the CI failure on CastXMLSuperbuild.

@hjmjohnson
Copy link
Author

@hjmjohnson hjmjohnson force-pushed the 216-Followup-MSVC-fix branch from c3ad480 to 326d18e Compare December 20, 2025 13:44
@hjmjohnson hjmjohnson force-pushed the 216-Followup-MSVC-fix branch from 326d18e to 60944e0 Compare December 20, 2025 16:52
@hjmjohnson
Copy link
Author

hjmjohnson commented Dec 20, 2025

@bradking @thewtex This PR allows targeted exclusion of the test that is incompatible with the github CI infrastructure.

@hjmjohnson
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants