Cleanup: Draft effect, pass 1#9696
Merged
tool4ever merged 1 commit intoCard-Forge:masterfrom Feb 9, 2026
Merged
Conversation
dracontes
added
the
Card Cleanup
Hanmac
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here, it was noticed that
Drafteffect lines with theZone$parameter weren't putting the card in hand before putting it in the zone stated in the parameter, when the ability is described in such a way and gameplay footage shows the drafted cards going to the hand before going anywhere else. This situation, among other things, has effects that exile drafted cards not trigger Ranar the Ever-Watchful.In the interest of having things working as expected, and that seek and draft follow the same pattern for ease of scripting, herein I removed the
Zone$parameter from theDraftlines and added relevantChangeZonelines. Cards were tested to satisfaction and some germane issues were resolved at the same time, mostly regarding Stack messages.Admittedly my Java expertise isn't sufficient to confidently edit
DraftEffect.javato remove the code this PR proposes to obsolete.