Restore default screen orientation autodetection #9676
+68
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When the user doesn't pass 'portrait', 'landscape', or 'height/width', fall back to the original behavior auto detecting monitor orientation. * Use monitor aspect ratio to inform width/height when only one is set via command line. * Add helper method to signal to Forge that the user is overriding the default orientation.
tool4ever
reviewed
Feb 6, 2026
| boolean hasAnyDimArg = (widthArg != null || heightArg != null); | ||
| boolean hasBothDims = (widthArg != null && heightArg != null); | ||
|
|
||
| boolean manualWindowSize = hasAnyDimArg; |
Contributor
There was a problem hiding this comment.
should clean up some of these booleans
these command line arguments don't really need their own ones if you're just going to reassign them to another anyway
just makes things messier
tool4ever
reviewed
Feb 6, 2026
| } | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
imo if the size from settings is used it shouldn't be messed with
or at the very least only if the orientation arguments are actually provided
otherwise you're making it more difficult to freely combine both parts in case the screen size is big enough for either mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9654