Fixes and Features#85
Open
Netzvamp wants to merge 10 commits intoCampbellSoftwareSolutions:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i've looked into your Dockerfile as a base for my ticket system and found things to fix and needed some features i've added.
Here we go:
MYSQL_PASSWORD_FILE,INSTALL_SECRET_FILE,ADMIN_PASSWORD_FILE,SMTP_PASSWORD_FILEto provide secrets outside of env variables with paths to files.docker-compose-swarm.ymlWith all things added the compressed image is only 5 MB greater than without all languages and plugins. Looks efficient for me...
I've tested it locally and in my swarm, but it could be nice to have some other use cases tested
Greetings, Robert