Get rid of construct.Embedded to support python version >3.11#25
Open
MohammedAdain wants to merge 1 commit intoCaliDog:masterfrom
Open
Get rid of construct.Embedded to support python version >3.11#25MohammedAdain wants to merge 1 commit intoCaliDog:masterfrom
MohammedAdain wants to merge 1 commit intoCaliDog:masterfrom
Conversation
Author
Author
|
I built a new version of axeman locally and tested and both of them seem to work just fine. |
|
@MohammedAdain Works for me (with small patch for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The construct.Embedded feature has been removed in newer versions of the Construct library, as substructure fields are now automatically flattened in most cases. If you’re using a modern version of Construct, you can safely remove Embedded from your code, and the fields from the substructure should still be accessible as part of the parent structure.