Skip to content

Conversation

@liptakpanna
Copy link
Contributor

The goal is that the Preserve Platform dev and QA instance can use the Notification role and only for production it will obtain an API key with read all permission.

@liptakpanna liptakpanna force-pushed the update-archiver-permission branch from 8cbdbde to 44ab973 Compare February 12, 2026 14:18
@kpsherva kpsherva moved this to In review 🔍 in Sprint Q1/2026 Feb 12, 2026


class Archiver(Generator):
class ArchiverReader(Generator):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ArchiverReader(Generator):
class ArchiverRole(Generator):
@property
def archiver_role():
raise NotImplementedError()
def needs(self, **kwargs):
"""Enabling Needs."""
return [self.archive_role]
def query_filter(self, identity=None, **kwargs):
"""Filters for current identity as system process."""
for need in identity.provides:
if need == self.archiver_role:
return dsl.Q("match_all")
else:
return []
...


class Librarian(Generator):
"""Allows librarian role."""
class ArchiverNotification(Generator):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ArchiverNotification(Generator):
class ArchiverNotification(ArchiverRole):
@property
def archiver_role():
return archiver_notification_role

@liptakpanna liptakpanna force-pushed the update-archiver-permission branch from 44ab973 to 0350547 Compare February 12, 2026 15:23
@liptakpanna liptakpanna force-pushed the update-archiver-permission branch 5 times, most recently from a6057ef to 218b9ec Compare February 12, 2026 15:52
@liptakpanna liptakpanna force-pushed the update-archiver-permission branch from 218b9ec to 430c396 Compare February 12, 2026 16:03
@zzacharo zzacharo merged commit 11e6266 into CERNDocumentServer:master Feb 12, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from In review 🔍 to To release 🤖 in Sprint Q1/2026 Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants