Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves session management by implementing session validation and reuse strategies to optimize database connection handling. The changes focus on preventing unnecessary session closures and adding validation to ensure sessions remain healthy before reuse.
- Adds session validation logic to check connection health before reusing cached sessions
- Modifies session lifecycle to prevent premature closure and enable session reuse
- Introduces explicit session cleanup method for controlled shutdown scenarios
dynamicannotationdb/database.py
Outdated
| if not hasattr(session, 'bind') or session.bind is None: | ||
| return False | ||
| # Try a simple query to test the connection | ||
| session.execute("SELECT 1") |
There was a problem hiding this comment.
The session validation query should use session.execute(text("SELECT 1")) to properly handle the SQL string. SQLAlchemy 2.0+ requires explicit text() wrapper for raw SQL strings.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.