Trust binaries signed for Waterfox again (about:third-party)
#3978
+174,565
−4,335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 662d2ae)
Also includes: * feat: improve support for bootstrapped extensions Added support for custom preference pages. * fix: incorrect loading order for bootstrap loader * fix: BootstrapLoader (cherry picked from commit eb40811)
(cherry picked from commit 406d531)
(cherry picked from commit 15940da)
(cherry picked from commit 02227c4)
(cherry picked from commit 1ba55e4)
(cherry picked from commit 84e6698)
(cherry picked from commit ec70e94)
(cherry picked from commit c890953)
(cherry picked from commit 0e34696)
…tions update method to handle missing updateInstall
(cherry picked from commit d97ab04)
(cherry picked from commit 247e35b)
(cherry picked from commit 64e891c)
(cherry picked from commit 9a06eb5)
(cherry picked from commit 5a17f99)
(cherry picked from commit 7561b24)
(cherry picked from commit 09d6df4)
(cherry picked from commit b10ab25)
(cherry picked from commit 0824e0f)
(cherry picked from commit 23cef47)
(cherry picked from commit f959b3e)
(cherry picked from commit 2a4f2f9)
MrAlex94
force-pushed
the
current
branch
3 times, most recently
from
7d8f658 to
c7662e5
Compare
Collaborator
|
Thanks, squashed into 2a74b9a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same principle as #3269
The string matching is checking against exact strings and the signature's letter casing was changed causing this issue to reappear. I don't know if the old letter casing for the signature is officially retired or is subject to return at any point (I'm unfamiliar with the process around acquiring or managing digital signatures), but If you don't plan on ever using the old letter casing for signing again then it's probably better to just replace the old BrowserWorks string check with the new string rather then adding a whole new check on-top like I've done here.