Conversation
ghost
reviewed
Mar 3, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Without echoing the data into and for sed to parse, sed will just sit, waiting for STDIN, so I would say in this case, the pipe is needed. If "$1" is a filename, then yeah, I agree, provided the filename is appended to the sed command.
Also, I really think that line should be split up a bit, because it's madness as it is now, IMO.
ghost
reviewed
Mar 3, 2020
Co-Authored-By: Terminal for Life <31768530+terminalforlife@users.noreply.github.com>
|
I used 4-space indenting, by the way, but I can't remember which style Brodie uses, so you might want to fix that in-case it's not 4-spaces (actual whitespaces). I'd have just tabbed, but GitHub doesn't seem to want me to do that. xD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.