Add stack implementation in JavaScript#55
Open
richardartoul wants to merge 2 commits intoBradfield:masterfrom
Open
Add stack implementation in JavaScript#55richardartoul wants to merge 2 commits intoBradfield:masterfrom
richardartoul wants to merge 2 commits intoBradfield:masterfrom
Conversation
Contributor
|
I actually like the asserts when they serve an illustrative purpose for the reader. I haven't yet encountered a situation where I wanted JavaScript tests that were not also illustrative for the reader, but only at that point would I set up some other js testing system. Up to you though. Regarding the CI fail, you'll need to add the gross "coding" magic comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
I added a Javascript implementation for stacks. I have a question before merging:
The JavaScript testing system seems to run all the code samples through Node (after injecting the assert library) whereas the Python testing system runs the separate unit test files. How do you want me to handle testing the JavaScript stuff? I think it'll look weird if we have assert statements in all the JavaScript code samples, but not in the Python code samples. Its not the end of the world though. Would you rather I continue doing that (in which case I'll add tests to this pull request) or that I set up some generic JavaScript testing system we can use?