Changing representation of base case to help understand form of recursion#117
Open
bharatagarwal wants to merge 1 commit intoBradfield:masterfrom
Open
Changing representation of base case to help understand form of recursion#117bharatagarwal wants to merge 1 commit intoBradfield:masterfrom
bharatagarwal wants to merge 1 commit intoBradfield:masterfrom
Conversation
Collaborator
|
I agree this is a bit confusing. Is it also worth changing the text, which currently says "A tower of one disk will be our base case." (the base case should be a tower of zero disks)? Alternatively, should we have something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an opinionated suggestion, feel free to not merge.
I think the fact that
height == 0is the base case for the function is implicit, and maps slightly separately to the way the text talks about the base case.By making a return explicit when height == 0, it helps to visualise how the call stack is being used.