Moving deque implementation to its own file#113
Open
bharatagarwal wants to merge 3 commits intoBradfield:masterfrom
Open
Moving deque implementation to its own file#113bharatagarwal wants to merge 3 commits intoBradfield:masterfrom
bharatagarwal wants to merge 3 commits intoBradfield:masterfrom
Conversation
Collaborator
robot-dreams
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Comment on lines
+5
to
+26
| cases = ( | ||
| (lambda d: d.is_empty(), [], True), | ||
| (lambda d: d.add_rear(4), [4], None), | ||
| (lambda d: d.add_rear('dog'), ['dog', 4], None), | ||
| (lambda d: d.add_front('cat'), ['dog', 4, 'cat'], None), | ||
| (lambda d: d.add_front(True), ['dog', 4, 'cat', True], None), | ||
| (lambda d: d.size(), ['dog', 4, 'cat', True], 4), | ||
| (lambda d: d.is_empty(), ['dog', 4, 'cat', True], False), | ||
| (lambda d: d.add_rear(8.4), [8.4, 'dog', 4, 'cat', True], None), | ||
| (lambda d: d.remove_rear(), ['dog', 4, 'cat', True], 8.4), | ||
| (lambda d: d.remove_front(), ['dog', 4, 'cat'], True) | ||
| ) | ||
|
|
||
|
|
||
| class TestCorrectness(unittest.TestCase): | ||
|
|
||
| def test_operates_correctly(self): | ||
| deque = Deque() | ||
| for operate, expected_state, expected_return in cases: | ||
| actual_return = operate(deque) | ||
| self.assertEqual(actual_return, expected_return) | ||
| self.assertEqual(deque._items, expected_state) |
Collaborator
There was a problem hiding this comment.
How would you feel about something like this instead?
cases = (
(Deque.is_empty, [], [], True),
(Deque.add_rear, [4], [4], None),
(Deque.add_rear, ['dog'], ['dog', 4], None),
(Deque.add_front, ['cat'], ['dog', 4, 'cat'], None),
(Deque.add_front, [True], ['dog', 4, 'cat', True], None),
(Deque.size, [], ['dog', 4, 'cat', True], 4),
(Deque.is_empty, [], ['dog', 4, 'cat', True], False),
(Deque.add_rear, [8.4], [8.4, 'dog', 4, 'cat', True], None),
(Deque.remove_rear, [], ['dog', 4, 'cat', True], 8.4),
(Deque.remove_front, [], ['dog', 4, 'cat'], True)
)
class TestCorrectness(unittest.TestCase):
def test_operates_correctly(self):
deque = Deque()
for method, args, expected_state, expected_return in cases:
actual_return = method(deque, *args)
self.assertEqual(actual_return, expected_return)
self.assertEqual(deque._items, expected_state)Co-authored-by: Elliott Jin <4276679+robot-dreams@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the deque implementation to its own file. Also fixed a typo involving a missing backtick in the table demonstration deque operations.
Note: Removed
(object)from class declaration along the lines of #112